GIF encoding with partial frames and transparency #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The GIF encoder did not properly support animated GIFs with partial frames (frames smaller than the
canvas that are positioned at an offset). This caused animated GIF round-trips to produce corrupted
output.
Issues:
Solution
src/utils/gif_encoder.tsAdded
GIFFrameDatainterface with frame metadata (left, top, width, height, disposal)Updated
addFrame()signature to accept optional frame metadata:Updated
quantize()to handle transparency:Updated
encode()to use frame metadata:src/formats/gif.tsencodeFrames()to pass frame metadata to encodermapDisposalMethodToNumber()helper functionBackward Compatibility
The changes are backward compatible. The
addFrame()method still works with just(data, delay)-frame metadata is optional with sensible defaults.