Fix get_unchecked panic by raw pointer calculation#940
Merged
bors[bot] merged 1 commit intocrossbeam-rs:masterfrom Dec 16, 2022
Merged
Fix get_unchecked panic by raw pointer calculation#940bors[bot] merged 1 commit intocrossbeam-rs:masterfrom
bors[bot] merged 1 commit intocrossbeam-rs:masterfrom
Conversation
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Contributor
|
Build succeeded:
|
Merged
bors bot
added a commit
that referenced
this pull request
Dec 27, 2022
944: Run cargo-careful in CI r=taiki-e a=taiki-e https://github.com/RalfJung/cargo-careful This allows to catch UB like #940. Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot
added a commit
that referenced
this pull request
Dec 27, 2022
944: Run cargo-careful in CI r=taiki-e a=taiki-e https://github.com/RalfJung/cargo-careful This allows to catch UB like #940. 945: Prepare for the next release r=taiki-e a=taiki-e - crossbeam-skiplist 0.1.1 - Fix `get_unchecked` panic by raw pointer calculation. (#940) Also, I'll yank crossbeam-skiplist 0.1.0 once 0.1.1 is released. Co-authored-by: Taiki Endo <te316e89@gmail.com>
|
any updates in tikv ? my tikv6.5 panic with the same panic backtrace in components/cdc, which reference to currency_manager::lock_table::skiplist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is related to #878 but doesn't fix it. Miri still complains with this PR.
It fixes the panic on recent toolchains (after rust-lang/rust#92686) when using
-Zbuild-std.