feat: initial implementation#2
Merged
Merged
Conversation
9874cb2 to
bfb5b77
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a reference implementation of a Pipeline Inspector sidecar for Crossplane that captures function pipeline execution data (requests and responses) and logs them to stdout.
Changes:
- Implements a gRPC server that listens on a Unix socket and logs pipeline inspection events
- Supports both JSON and human-readable text output formats
- Includes comprehensive test coverage for the inspector functionality
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| main.go | Entry point with CLI parsing, gRPC server setup, and graceful shutdown handling |
| server/server.go | Core Inspector implementation with JSON and text formatters |
| server/server_test.go | Comprehensive unit tests for Inspector functionality |
| go.mod | Module definition with dependencies |
| go.sum | Dependency checksums |
| Dockerfile | Multi-stage build using distroless base image |
| README.md | Documentation with usage examples and configuration options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
bfb5b77 to
daf3fe8
Compare
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
From crossplane/crossplane#7025.
Fixes #
I have: