Skip to content

Allow the date-time separating string to be configurable#3

Open
Gibbonator wants to merge 1 commit into
crossxcell99:masterfrom
Gibbonator:master
Open

Allow the date-time separating string to be configurable#3
Gibbonator wants to merge 1 commit into
crossxcell99:masterfrom
Gibbonator:master

Conversation

@Gibbonator

Copy link
Copy Markdown

Can be added to config under key 'dateTimeSeparator'
Defaults to the previous fixed value.
Documentation amended to include new property.
Aim is to provide some some further control over the formatting while not requiring any changes for existing usages.

Defaults to the previous fixed value.

@zxcpoiu zxcpoiu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/crossxcell99/dtsel/pull/3/files#diff-42625026986102b6913ac2f39ea66749753f910fee8b9f23feeb763673954c0eR221

should be

-var parts = self.elem.value.split(/\s*,\s*/);
+var parts = self.elem.value.split(/\s* \s*/); // --- should be `this.settings.dateTimeSeparator`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants