Bump version to 0.4.0#3
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request synchronizes the project's version number across all relevant configuration and source files to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR correctly bumps the version to 0.4.0 in pyproject.toml, __init__.py, and server.py. However, this manual process across multiple files is error-prone. I've left a suggestion to consolidate the version number to a single source of truth to simplify future version bumps. Additionally, I noticed the version number is also hardcoded in Containerfile (line 30) and is currently out of date (0.2.0). While this file isn't part of the current changes, it would be beneficial to update it as well to ensure consistency across the project.
| [project] | ||
| name = "mcp-trove-crunchtools" | ||
| version = "0.3.0" | ||
| version = "0.4.0" |
There was a problem hiding this comment.
To avoid manually updating the version in multiple files, consider making pyproject.toml the single source of truth. You can then read the version dynamically in your code using importlib.metadata. This prevents inconsistencies and simplifies future version bumps.
For example:
In src/mcp_trove_crunchtools/__init__.py:
from importlib import metadata
try:
__version__ = metadata.version("mcp-trove-crunchtools")
except metadata.PackageNotFoundError:
# package is not installed, e.g., in development
__version__ = "0.0.0-dev"Then, in src/mcp_trove_crunchtools/server.py, you can simply import it:
from . import __version__
mcp = FastMCP(
"mcp-trove-crunchtools",
version=__version__,
# ...
)This change would make version management more robust.
Summary
trove_qualitytool added in feat: per-file error tracking with trove_quality tool #2Test plan
v0.4.0, confirm GHA rebuild triggers🤖 Generated with Claude Code