Add cost, hours, and mobility fields to POIs#183
Conversation
Adds cost, operating hours, and mobility accessibility fields to POIs. Enables trip planning based on budget, schedule, and physical limitations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds essential trip planning metadata to POIs: - Cost field (free, low, medium, high) for budget planning - Hours field (freeform text) for operating hours/availability - Mobility field (full, limited, accessible) for accessibility Database changes: - Migration 017: Adds cost, hours, mobility columns with CHECK constraints - All fields nullable for backward compatibility Backend changes: - Updated POST/PUT /api/admin/pois to accept new fields - Database constraints enforce valid enum values Frontend changes: - Added new fields to POI detail view Visitor Information section - Icons for cost, hours, mobility fields - Added admin form inputs (dropdowns + text field) Testing: - Integration tests for API endpoints - Manual API testing verified all endpoints Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces cost, hours, and mobility metadata fields for POIs, featuring a database migration with CHECK constraints, backend route updates, integration tests, and frontend UI enhancements for viewing and editing. Feedback identifies a need for backend validation to prevent database errors from invalid inputs and recommends refactoring repetitive conditional rendering logic in the frontend components to improve maintainability.
| 'events_url', 'news_url', 'research_context', | ||
| 'length_miles', 'difficulty', 'boundary_type', 'boundary_color' | ||
| 'length_miles', 'difficulty', 'boundary_type', 'boundary_color', | ||
| 'cost', 'hours', 'mobility' |
There was a problem hiding this comment.
The new fields 'cost', 'hours', and 'mobility' are added to the allowedFields array, but there is no corresponding validation logic implemented to ensure these fields adhere to the database constraints (e.g., checking if 'cost' is one of the allowed enum values) before they are passed to the database query. This could lead to database errors if invalid data is submitted.
| {destination.cost === 'free' ? 'Free' : | ||
| destination.cost === 'low' ? 'Low ($1-10)' : | ||
| destination.cost === 'medium' ? 'Medium ($11-25)' : | ||
| destination.cost === 'high' ? 'High ($26+)' : destination.cost} |
There was a problem hiding this comment.
The conditional rendering logic for the cost display is repetitive. Consider using a mapping object or a lookup function to improve readability and maintainability.
References
- Code should be clean and maintainable. Repetitive conditional logic should be refactored. (link)
| {destination.mobility === 'accessible' ? '♿ Accessibility' : | ||
| destination.mobility === 'limited' ? '⚠️ Accessibility' : | ||
| destination.mobility === 'full' ? '🥾 Accessibility' : 'Accessibility'} |
There was a problem hiding this comment.
The conditional rendering logic for mobility icons is repetitive. Consider using a mapping object or a lookup function to improve readability and maintainability.
References
- Code should be clean and maintainable. Repetitive conditional logic should be refactored. (link)
|
Closing as stale — codebase has moved significantly since April. Will re-evaluate if needed. |
1 participant
Summary
Adds essential trip planning metadata to POIs: cost, operating hours, and mobility accessibility levels. These fields enable users to filter and plan visits based on budget, schedule constraints, and physical accessibility needs.
Closes #7
Changes
Database (Migration 017)
costVARCHAR(50) with CHECK constraint (free, low, medium, high)hoursTEXT for freeform operating hoursmobilityVARCHAR(50) with CHECK constraint (full, limited, accessible)Backend API
Frontend
Test plan
🤖 Generated with Claude Code