fix: POI filter matches activities and unifies icon taxonomy (#410)

[fatherlinux]

Summary

• POI filter now searches activities, not just icon type — typing "camping" shows all POIs with camping as an activity
• Icon chip filter includes activity-matched POIs — clicking Camping chip shows 7 POIs (was 3)
• Unified activity/icon taxonomy: 4 new icons (Fishing, Kayaking, Scenic, Art), Nature gets Photography + Bird Watching fallbacks
• Renamed Visitor Center → Discovery (covers museums, libraries, visitor centers)
• Disabled "Other" icon type — all point POIs now map to real types
• Fixed orphaned POIs: Gear Up Velo → biking, John Brown Monument → historic, soft-deleted duplicate Brecksville Reservation

Closes #410

Test plan

• Type "camping" in map search → shows Heritage Farms + all camping POIs
• Click Camping chip only → shows all 7 camping-activity POIs on map
• New icons (Fishing, Kayaking, Scenic, Art) render in legend
• "Other" chip no longer appears
• "Discovery" label shows on the i icon
• All chips enabled → no regression, all POIs visible

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request introduces a database migration to unify activities and icons, adding new icon types (fishing, kayaking, scenic, art) with corresponding SVG files, updating fallbacks, and syncing the activities table. It also updates the frontend to support searching and filtering POIs by name or activity, and adjusts map bounds tracking. The review feedback highlights a correctness discrepancy in map bounds calculation, warns against hardcoding specific database IDs in SQL migrations, and suggests caching split fallbacks in poiMatchesActivityForTypes to improve performance.

[gemini-code-assist]

There is a correctness discrepancy between how typeBoundsById matches activities (using substring matching via includes) and how poiMatchesActivityForTypes matches them (using whole-word matching via matchesWholeWord). This can cause typeBoundsById to include a POI in the bounds for an icon type even though that POI is not actually rendered on the map for that type, leading to incorrect map zoom/bounds fitting. We can fix this and improve performance by reusing poiMatchesActivityForTypes with a single reused Set instance.

      const poiActs = (dest.primary_activities || '').toLowerCase();
      if (poiActs && iconConfig) {
        const tempSet = new Set();
        for (const icon of iconConfig) {
          if (icon.enabled === false || !icon.activity_fallbacks || icon.name === t) continue;
          tempSet.clear();
          tempSet.add(icon.name);
          if (poiMatchesActivityForTypes(dest, tempSet, iconConfig)) {
            addToBounds(icon.name, lat, lng);
          }
        }
      }

[gemini-code-assist]

Hardcoding specific database IDs (like 5745) in migrations is risky because IDs can differ across environments (development, staging, production) due to different insertion orders or manual edits. Since you are already filtering by name and poi_roles, you can safely remove the hardcoded id filter to make the migration robust across all environments.

UPDATE pois SET deleted = true WHERE name = 'Brecksville Reservation' AND 'point' = ANY(poi_roles);

[gemini-code-assist]

The poiMatchesActivityForTypes function is called repeatedly for many POIs during rendering and map movement. Splitting and mapping icon.activity_fallbacks on every single call is highly inefficient. We can cache the split and normalized fallbacks using a WeakMap on globalThis to avoid redundant string operations and significantly improve performance.

export function poiMatchesActivityForTypes(poi, visibleTypes, iconConfig) {
  if (!iconConfig || iconConfig.length === 0) return false;
  const poiActivities = (poi.primary_activities || '').toLowerCase();
  if (!poiActivities) return false;

  if (!globalThis._iconFallbackCache) {
    globalThis._iconFallbackCache = new WeakMap();
  }
  const cache = globalThis._iconFallbackCache;

  for (const icon of iconConfig) {
    if (icon.enabled === false) continue;
    if (!visibleTypes.has(icon.name)) continue;
    if (!icon.activity_fallbacks) continue;

    let fallbacks = cache.get(icon);
    if (!fallbacks) {
      fallbacks = icon.activity_fallbacks.split(',').map(a => a.trim().toLowerCase());
      cache.set(icon, fallbacks);
    }

    for (const fb of fallbacks) {
      if (fb && matchesWholeWord(poiActivities, fb)) return true;
    }
  }
  return false;
}