Skip to content

fix: bigger water-taxi boat marker + darker unread notification tint#449

Merged
fatherlinux merged 3 commits into
masterfrom
fix/boat-size-notification-halo
May 29, 2026
Merged

fix: bigger water-taxi boat marker + darker unread notification tint#449
fatherlinux merged 3 commits into
masterfrom
fix/boat-size-notification-halo

Conversation

@fatherlinux
Copy link
Copy Markdown
Member

Summary

Two small UI tweaks requested by Scott:

  • Water-taxi boat marker 30% biggercreateBoatIcon SVG 20×32 → 26×42, iconSize/iconAnchor scaled to match. Easier to spot on the map.
  • Unread notification tint darkened.notification-item.unread background #f3f8ee#dcebc6. The old near-white tint was hard to distinguish from read items against the white panel.

Test plan

  • GHA build green
  • Boat marker visibly larger on the map (live water-taxi tracker)
  • Unread notifications clearly tinted vs read ones

- Boat marker (createBoatIcon) scaled ~30%: 20x32 -> 26x42, anchor adjusted.
- Unread notification row tint #f3f8ee -> #dcebc6 (was near-white, hard to see).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the background color of unread notification items in App.css and increases the dimensions of the boat icon SVG and Leaflet marker configuration in Map.jsx. A review comment identifies an accessibility issue where the new background color results in insufficient contrast with the metadata text, and suggests darkening the text color specifically for unread notifications to meet WCAG 2.1 Level AA standards.

Comment thread frontend/src/App.css
Comment on lines 15089 to 15091
.notification-item.unread {
background: #f3f8ee;
background: #dcebc6;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new background color #dcebc6 for unread notifications combined with the meta text color #777 (defined in .notification-meta) results in a contrast ratio of approximately 3.6:1. This falls below the WCAG 2.1 Level AA minimum contrast requirement of 4.5:1 for normal text, which may make timestamps and other metadata difficult to read for users with visual impairments.

To resolve this while keeping the darker background, we can darken the meta text color specifically for unread notification items to #555 (which yields a contrast ratio of 6.0:1).

.notification-item.unread {
  background: #dcebc6;
}
.notification-item.unread .notification-meta {
  color: #555;
}

fatherlinux and others added 2 commits May 29, 2026 12:02
…ication-halo

# Conflicts:
#	frontend/src/components/Map.jsx
…urmand gate)

Pre-existing violation from #448 surfaced by the merge; rename to readsRows.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@fatherlinux fatherlinux merged commit 7dde8f9 into master May 29, 2026
3 checks passed
@fatherlinux fatherlinux deleted the fix/boat-size-notification-halo branch May 29, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant