feat: respect the NO_COLOR environment variable - #4
Merged
Conversation
The --no-color flag and TTY detection already worked, but the widely adopted NO_COLOR convention (no-color.org, honored by ripgrep, eza, bat) was not checked anywhere. Wires it into both the report renderer and the spinner, and adds a --no-color flag to `crwl fix`, which had no way to silence its spinner's color at all before this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-colorand TTY detection worked, but the widely adoptedNO_COLORconvention (no-color.org, honored by ripgrep, eza, bat, and most modern CLIs) was never checked.NO_COLORinto both the report renderer and the spinner (which previously ignored--no-colorentirely and always emitted color codes on a real TTY regardless of the flag).--no-colortocrwl fix, which had no way to silence its spinner's color before this (would have errored with "flag provided but not defined" if anyone tried).Test plan
go build,go vet,go test ./...all cleanscript): a plain run shows\033[1m/\033[31mescape codes;NO_COLOR=1strips them entirely while output content is byte-identical otherwise