fix(Ask Terax): make Ask Terax Ctrl+L shortcut work - #1058
Open
Aryan-Srivastava wants to merge 2 commits into
Open
fix(Ask Terax): make Ask Terax Ctrl+L shortcut work#1058Aryan-Srivastava wants to merge 2 commits into
Aryan-Srivastava wants to merge 2 commits into
Conversation
…ate shortcut key from 'j' to 'l'
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesAsk Terax shortcut
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/modules/ai/components/SelectionAskAi.tsx`:
- Line 60: Update the popup width constant W used by the positioning logic in
SelectionAskAi to 130, matching the button’s min-w-[130px] geometry. Preserve
the existing positioning calculations so the popup remains aligned near viewport
edges.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f035f455-cd5f-4c36-8589-2be0a7dab605
📒 Files selected for processing (3)
src/app/App.tsxsrc/modules/ai/components/SelectionAskAi.tsxsrc/modules/shortcuts/shortcuts.ts
…st className for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Ask Terax popup showed Ctrl+L, but pressing it did nothing. Only clicking the button worked. This fix makes Ctrl+L work again and keeps the badge in sync with the real shortcut.
Why
Closes #1057
How
Testing
pnpm lintcleanpnpm check-typescleanpnpm testcleansrc-tauri/)cargo clippy --all-targets --locked -- -D warningscleansrc-tauri/)cargo nextest run --lockedclean (orcargo test --locked)#[tauri::command]signature) called out below so the FE caller can be updated in locksteppnpm tauri devScreenshots / GIFs
Notes for reviewer
Summary by CodeRabbit
New Features
Bug Fixes