Skip to content

Added Bitcoin testnet4 support and parallel network queries - #44

Merged
embarquech merged 3 commits into
mainfrom
feature/btc_transaction
Apr 2, 2026
Merged

embarquech merged 3 commits into
mainfrom
feature/btc_transaction

Conversation

@YanNaingWinn

Copy link
Copy Markdown
Contributor

No description provided.

@YanNaingWinn
YanNaingWinn requested a review from embarquech March 26, 2026 19:47
Comment thread cryptnox_cli/command/card/info.py Outdated

# Phase 2: query all network balances in parallel
with ThreadPoolExecutor(max_workers=4) as executor:
f_btc = executor.submit(Info._get_btc_info, card, btc_pubkey)

@embarquech embarquech Mar 27, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both lines 58-59 are calling card, which is not thread safe.

@embarquech embarquech reopened this Apr 1, 2026
@embarquech
embarquech merged commit 0b8e207 into main Apr 2, 2026
12 checks passed
@YanNaingWinn
YanNaingWinn deleted the feature/btc_transaction branch June 3, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants