Repository navigation
Treat the Discovery Object as optional in the PIV state - #22
Merged
Merged
Conversation
Derive the mandatory object set from the PIV object registry (CHUID and CCC). Discovery is optional in PIV and no built-in profile creates it, so a complete card never reached PivPersonalized. Report finalize in `preperso status` under the rule the finalize command applies (applet selectable, not SECURED) and add `load_config_allowed` for the blank-applet case. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive the mandatory PIV object set from the object registry (CHUID and CCC). Discovery is optional and no built-in profile creates it, so it must not block
PivPersonalized. It is still probed and listed inobjects_present.factory piv preperso statusreportsfinalize_allowedunder the gate thefinalizecommand applies (applet selectable, not SECURED) and addsload_config_allowedfor a blank applet. The human output separates the two lines.Read-only detection of SECURED is unchanged (
Finalized (SECURED): no/undetermined).Tests:
tests/unit/test_state_discovery_optional.py,tests/unit/test_preperso_status_gate.py.🤖 Generated with Claude Code