fix: flaky TestByzantinePrevoteEquivocation and psql Docker port conflict#30
Open
JayT106 wants to merge 3 commits intocrypto-org-chain:v0.38.xfrom
Open
fix: flaky TestByzantinePrevoteEquivocation and psql Docker port conflict#30JayT106 wants to merge 3 commits intocrypto-org-chain:v0.38.xfrom
JayT106 wants to merge 3 commits intocrypto-org-chain:v0.38.xfrom
Conversation
…lict
- Remove 20s hardcoded timeout in TestByzantinePrevoteEquivocation that
flakes in slow CI. Use blocking wg.Wait() instead, relying on the
test's -timeout flag for overall deadline.
- Explicitly bind PostgreSQL container port to a random host port (":0")
to avoid "address already in use" when port 5432 is taken by a local
PostgreSQL or a parallel test run.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move PortBindings to RunOptions (so it's set before dockertest applies PublishAllPorts) and disable PublishAllPorts in the HostConfig callback. This ensures Docker only creates a single random-port binding instead of also trying to publish all exposed ports, which can race on CI and cause "address already in use" errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time.Aftertimeout inTestByzantinePrevoteEquivocationthat flakes in slow CI environments. Use a blockingwg.Wait()instead, relying on the test's-timeoutflag (default 10m) for the overall deadline.HostPort: "0") to avoidaddress already in useerrors when port 5432 is occupied by a local PostgreSQL instance or a parallel test run.