perf(mempool): replace proto marshaling with arithmetic in ComputeProtoSizeForTxs#32
Open
JayT106 wants to merge 1 commit intocrypto-org-chain:v0.38.xfrom
Open
perf(mempool): replace proto marshaling with arithmetic in ComputeProtoSizeForTxs#32JayT106 wants to merge 1 commit intocrypto-org-chain:v0.38.xfrom
JayT106 wants to merge 1 commit intocrypto-org-chain:v0.38.xfrom
Conversation
ComputeProtoSizeForTxs previously allocated a Data{} struct and
marshaled to protobuf per call, causing O(n) allocations in the hot
ReapMaxBytesMaxGas path. Replace with direct arithmetic (tag byte +
varint length + data) that matches the protobuf wire format exactly.
Benchmarks show ~2x speedup and allocations drop from 1-per-tx to 1
total across all mempool sizes.
Backport of cometbft#5694.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of cometbft/cometbft#5694.
ComputeProtoSizeForTxspreviously allocated aData{}struct and marshaled to protobuf per call, causing O(n) allocations in the hotReapMaxBytesMaxGaspathtag byte + varint length + data) that matches the protobuf wire format exactly