Skip to content

chore(deps): bump protobuf from 4.25.8 to 6.33.5 in /integration_tests#1969

Merged
JayT106 merged 3 commits intomainfrom
dependabot/pip/integration_tests/protobuf-6.33.5
Apr 16, 2026
Merged

chore(deps): bump protobuf from 4.25.8 to 6.33.5 in /integration_tests#1969
JayT106 merged 3 commits intomainfrom
dependabot/pip/integration_tests/protobuf-6.33.5

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Jan 30, 2026

Bumps protobuf from 4.25.8 to 6.33.5.

Release notes

Sourced from protobuf's releases.

Protocol Buffers v34.0-rc1

Announcements

Bazel

Compiler

C++

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 4.25.8 to 6.33.5.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-version: 6.33.5
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 30, 2026
@dependabot dependabot Bot requested a review from a team as a code owner January 30, 2026 23:56
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 30, 2026
@dependabot dependabot Bot requested review from songgaoye and thomas-nguy and removed request for a team January 30, 2026 23:56
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 30, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 8, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedpypi/​protobuf@​4.25.8 ⏵ 6.33.5100100 +16100100100

View full report

@JayT106 JayT106 enabled auto-merge April 16, 2026 18:17
@JayT106
Copy link
Copy Markdown
Contributor

JayT106 commented Apr 16, 2026

@claude review this PR

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Claude finished @JayT106's task in 2m 50s —— View job


PR Review: chore(deps): bump protobuf from 4.25.8 to 6.33.5 in /integration_tests

  • Gather context and review changed files
  • Analyze compatibility and breaking changes
  • Post review feedback

Summary

This is a Dependabot-generated dependency bump updating protobuf from 4.25.8 to 6.33.5 — a major version jump (v4 → v6, skipping v5 entirely). The changes are minimal: pyproject.toml updates the exact pinned version and poetry.lock updates the corresponding checksums.

Positives

  • Security improvement: The Socket.dev scan shows the new version scores 100/100 across all categories, with +16 resolved vulnerabilities.
  • Python version alignment: protobuf v6 requires Python ≥ 3.9, which matches the project's python = "^3.9" constraint.
  • Checksums: The poetry.lock hashes look correctly updated for the new package artifacts.

Concerns

1. Generated pb2 files may be incompatible with protobuf v6

The project ships 12 hand-generated/committed protobuf files under integration_tests/protobuf/ that all use the old-style reflection API:

# integration_tests/protobuf/cosmos/tx/v1beta1/tx_pb2.py (and 11 others)
from google.protobuf import reflection as _reflection

Tx = _reflection.GeneratedProtocolMessageType('Tx', (_message.Message,), {...})

This pattern was deprecated in protobuf v3.x. In protobuf v5, the new code generator stopped producing it. In v6, deprecated Python APIs are actively removed (the PR description explicitly lists "[Python] Remove deprecated ..." entries). If reflection.GeneratedProtocolMessageType or symbol_database usage was cleaned up in v6, these files will raise import errors at test time.

These files were not regenerated as part of this PR — they remain as-is from their original generation with an older protoc.

Recommendation: Verify the integration tests actually pass with v6 by checking CI results. If they fail, the pb2 files should be regenerated using a v6-compatible protoc + protoc-gen-python.

2. Exact version pin instead of a range

# integration_tests/pyproject.toml
protobuf = "6.33.5"   # exact pin, no ^ or ~

The version is pinned exactly. While this is consistent with the previous 4.25.8 pin, consider whether a ^6.33.5 constraint (patch/minor updates allowed) would be better going forward so Dependabot can make smaller, lower-risk bumps rather than accumulating major jumps.

3. Python breaking changes in v6

Per the PR description (protobuf v34.0 release notes, which maps to the Python package v6.x):

  • Bool-to-int/enum field assignments now raise errors — if any test code assigns True/False to an integer protobuf field, that will now fail.
  • FieldDescriptor.label removed — if any code reads .label on a field descriptor it will break.
  • float_format/float_precision removed from text_format/json_format — unlikely to affect this project but worth noting.

Verdict

The lockfile and pyproject.toml changes themselves look correct. The main risk is runtime compatibility of the committed pb2 files with the new protobuf runtime. This should be caught by CI — confirm integration tests pass before merging.

@JayT106 JayT106 added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 4ae04f3 Apr 16, 2026
46 checks passed
@dependabot dependabot Bot deleted the dependabot/pip/integration_tests/protobuf-6.33.5 branch April 16, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant