fix(nix): enable LZ4 support for Windows builds#1983
Conversation
* fix(nix): LZ4 not build in windows * update ci build.yml * update lz4 * add objdump debug for rocksdb.nix * fix(nix): generate lz4 import lib from DLL exports on MinGW * add changelog * ci: smoke test Windows tarballs with wine * fix wine test * Update CHANGELOG.md Signed-off-by: Xinyu <91446598+XinyuCRO@users.noreply.github.com> --------- Signed-off-by: Xinyu <91446598+XinyuCRO@users.noreply.github.com> Co-authored-by: Xinyu <91446598+XinyuCRO@users.noreply.github.com>
📝 WalkthroughWalkthroughThe pull request adds Windows compatibility testing via Wine to the CI pipeline, enables LZ4 compression support for Windows RocksDB builds through improved DLL export handling and platform-specific adjustments, and documents the LZ4 fix in the changelog. Changes span CI configuration, Nix build logic, and release notes. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
backport nix window build fix
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Bug Fixes
Chores