Skip to content

chore: remove unused precompiles #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomas-nguy merged 5 commits into from
Mar 13, 2026
+8 −13
Merged

chore: remove unused precompiles #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b5a038
remove unused precompile
thomas-nguy Mar 13, 2026
9eece9b
update changelog
thomas-nguy Mar 13, 2026
e3e4d84
disable precompile tests
thomas-nguy Mar 13, 2026
9cc247a
fix changelog
thomas-nguy Mar 13, 2026
40e6004
fix lint
thomas-nguy Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@

* [#1979](https://github.com/crypto-org-chain/cronos/pull/1979) fix(testground): fix send_batch_size&send_interval setup failed in testground.

### Chores:
* [#1986](https://github.com/crypto-org-chain/cronos/pull/1986) Remove unused precompiles


*Jan 26, 2026*

## v1.7.0
Expand Down
14 changes: 1 addition & 13 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ import (
cronosclient "github.com/crypto-org-chain/cronos/x/cronos/client"
cronoskeeper "github.com/crypto-org-chain/cronos/x/cronos/keeper"
evmhandlers "github.com/crypto-org-chain/cronos/x/cronos/keeper/evmhandlers"
cronosprecompiles "github.com/crypto-org-chain/cronos/x/cronos/keeper/precompiles"
"github.com/crypto-org-chain/cronos/x/cronos/middleware"
// force register the extension json-rpc.
_ "github.com/crypto-org-chain/cronos/x/cronos/rpc"
Expand All @@ -57,11 +56,8 @@ import (
e2eekeyring "github.com/crypto-org-chain/cronos/x/e2ee/keyring"
e2eetypes "github.com/crypto-org-chain/cronos/x/e2ee/types"
"github.com/ethereum/go-ethereum/common"
// Force-load the tracer engines to trigger registration
"github.com/ethereum/go-ethereum/core/vm"
_ "github.com/ethereum/go-ethereum/eth/tracers/js"
_ "github.com/ethereum/go-ethereum/eth/tracers/native"
ethparams "github.com/ethereum/go-ethereum/params"
"github.com/evmos/ethermint/ante/cache"
evmenc "github.com/evmos/ethermint/encoding"
"github.com/evmos/ethermint/ethereum/eip712"
Expand Down Expand Up @@ -646,21 +642,13 @@ func New(
// Set authority to x/gov module account to only expect the module account to update params
evmS := app.GetSubspace(evmtypes.ModuleName)

gasConfig := storetypes.TransientGasConfig()
app.EvmKeeper = evmkeeper.NewKeeper(
appCodec,
keys[evmtypes.StoreKey], okeys[evmtypes.ObjectStoreKey], authtypes.NewModuleAddress(govtypes.ModuleName),
app.AccountKeeper, app.BankKeeper, app.StakingKeeper, app.FeeMarketKeeper,
tracer,
evmS,
[]evmkeeper.CustomContractFn{
func(_ sdk.Context, rules ethparams.Rules) vm.PrecompiledContract {
return cronosprecompiles.NewRelayerContract(app.IBCKeeper, appCodec, rules, app.Logger())
},
func(ctx sdk.Context, rules ethparams.Rules) vm.PrecompiledContract {
return cronosprecompiles.NewIcaContract(ctx, app.ICAControllerKeeper, &app.CronosKeeper, appCodec, gasConfig)
},
},
[]evmkeeper.CustomContractFn{},
cast.ToUint64(appOpts.Get(server.FlagQueryGasLimit)),
)

Expand Down
3 changes: 3 additions & 0 deletions integration_tests/test_ica_precompile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@

pytestmark = pytest.mark.ica

# skip ica precompile integration tests since it's not enabled by default.
pytest.skip("skipping ica precompile tests", allow_module_level=True)

CONTRACT = "0x0000000000000000000000000000000000000066"
connid = "connection-0"
no_timeout = 300000000000
Expand Down
Loading