Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.x #869 +/- ##
===================================================
+ Coverage 40.30% 42.61% +2.31%
===================================================
Files 190 195 +5
Lines 15647 16682 +1035
===================================================
+ Hits 6306 7109 +803
- Misses 8658 8856 +198
- Partials 683 717 +34
🚀 New features to boost your workflow:
|
964658e to
4e1561b
Compare
JayT106
reviewed
Mar 25, 2026
JayT106
reviewed
Mar 25, 2026
JayT106
reviewed
Mar 25, 2026
JayT106
reviewed
Mar 25, 2026
|
|
||
| // Enforce the gas limit cap | ||
| gasCap := req.GasCap | ||
| if k.queryMaxGasLimit != GasNoLimit { |
There was a problem hiding this comment.
what value do we set for queryMaxGasLimit? If we don't set it and the user request gasCap also unset. Does it mean user will run through the Max 256 blocks simulation?
Author
There was a problem hiding this comment.
here use the same check as eth_call
JayT106
reviewed
Mar 25, 2026
JayT106
reviewed
Mar 25, 2026
JayT106
reviewed
Mar 25, 2026
JayT106
reviewed
Mar 25, 2026
JayT106
reviewed
Mar 25, 2026
songgaoye
reviewed
Mar 26, 2026
songgaoye
reviewed
Mar 26, 2026
songgaoye
reviewed
Mar 26, 2026
songgaoye
reviewed
Mar 26, 2026
0273f83 to
eb9345f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)