Skip to content

fix: prevent nested StateDB storage overwrites#873

Open
XinyuCRO wants to merge 4 commits intorelease/v0.23.xfrom
Xinyu/fix-statedb
Open

fix: prevent nested StateDB storage overwrites#873
XinyuCRO wants to merge 4 commits intorelease/v0.23.xfrom
Xinyu/fix-statedb

Conversation

@XinyuCRO
Copy link
Copy Markdown

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-actions github-actions bot added the evm label Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.35%. Comparing base (e43268a) to head (aacf095).

Files with missing lines Patch % Lines
x/evm/keeper/state_transition.go 0.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.23.x     #873      +/-   ##
===================================================
+ Coverage            40.30%   40.35%   +0.05%     
===================================================
  Files                  190      190              
  Lines                15647    15669      +22     
===================================================
+ Hits                  6306     6324      +18     
- Misses                8658     8663       +5     
+ Partials               683      682       -1     
Files with missing lines Coverage Δ
x/evm/statedb/statedb.go 78.49% <100.00%> (+1.55%) ⬆️
x/evm/keeper/state_transition.go 73.62% <0.00%> (-2.71%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

XinyuCRO and others added 2 commits March 27, 2026 10:01
Signed-off-by: Xinyu <91446598+XinyuCRO@users.noreply.github.com>
@XinyuCRO XinyuCRO force-pushed the Xinyu/fix-statedb branch from 1995b98 to 96fc5c2 Compare March 27, 2026 02:01
@XinyuCRO XinyuCRO marked this pull request as ready for review March 27, 2026 02:02
@XinyuCRO XinyuCRO requested a review from a team as a code owner March 27, 2026 02:02
@XinyuCRO XinyuCRO requested review from randy-cro and thomas-nguy and removed request for a team March 27, 2026 02:02
@JayT106
Copy link
Copy Markdown

JayT106 commented Mar 27, 2026

Maybe can test the inner writes before outer reads case.

This change could be a breaking change if the issue already happening in the current network. Consider to update PR title with !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants