fix: prevent pool corruption from undefined boxId - #6
Merged
Conversation
…finally block - Guard pool.releaseBox() call with undefined check - Prevents undefined values from being pushed to availableBoxIds array - Fixes issue where HTTP_429 or other early errors could corrupt the box ID pool
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent pool.releaseBox(...) from being called with an undefined boxId during request cleanup in the /api/v1/execute handler, avoiding corruption of the pool’s available box ID list.
Changes:
- Adds an explicit
boxId !== undefinedguard around the isolate cleanup andpool.releaseBox(boxId)call in the handler’sfinallyblock. - Nests the cleanup/release logic under the new guard to avoid operating on an uninitialized box ID.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pool.releaseBox(boxId); | ||
| } catch (cleanupError) { | ||
| fastify.log.error(`Failed to cleanup box ${boxId}: ${cleanupError}`); | ||
| if (boxId !== undefined) { |
cryptomafiaPB
approved these changes
Jun 7, 2026
cryptomafiaPB
left a comment
cryptomafiaPB
left a comment
Owner
There was a problem hiding this comment.
The fix correctly avoids changing pool.releaseBox with undefined boxId, which would corrupt the pool state.
Overall, the changes looks good and address the issue/bug "[BUG] boxId Used Uninitialized in finally — Pool Corruption #5 ".
Improved workflow and added `pool.releaseBox(boxId)` in new finally block. Which ensures `boxId` does get released. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If
pool.acquireBox()throws an error (e.g., HTTP_429), the finally blockstill executes and calls
pool.releaseBox(boxId)whereboxIdis undefined.This pushes undefined into the availableBoxIds array, corrupting the pool.
Solution
Guard the releaseBox call with an undefined check.