Generate reva configuration from Helm Values#48
Generate reva configuration from Helm Values#48mirekys wants to merge 4 commits intocs3org:masterfrom
Conversation
There was a problem hiding this comment.
@mirekys very nice idea behind this PR, I love it!
However, I think as both a backwards-compatibility mechanism and to provide some flexibility in terms of being able to inject the .toml file directly (e.g. when migrating from existing non-kubernetes reva installations), it could be good to keep this logic as well as fallback.
For instance, when passing a file rather than individual config parameters - cc/ @labkode we discussed this a couple of years ago, what do you think?
Hi @SamuAlfageme, this change is already backwards-compatible. If someone wishes to inject toml file as a reva config, |
|
@dagl please review |
This PR allows chart users to modify individual settings of Reva daemon directly either
by Helm
values.yamlor byhelm upgrade ... --set config.some-reva-setting=valuemethod, ratherthan by rewriting the whole
revad.tomlfile. It also allows for inheritance of common Reva settings in subcharts,leveraging built-in Helm values inheritance.
Currently used way of configuring Reva using static toml files:
remains still possible.
Contributing a Chart / update to an existing Chart
helm linton the chart dir.Chart.yamlversion before merging, to release it as a new version.annotationson theChart.yamlwith:artifacthub.io/changes- the changes introduced on the PR with the appropiate format.artifacthub.io/images- the updated tag on thecs3org/revadimage.values.yaml. Add documentation in the appropiate README.