Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds file upload functionality to the Functions Access Service, expanding its capabilities beyond number generation to include methods for uploading files to the CIM Database Cloud.
Key changes:
- Refactored service architecture to use metadata-based initialization instead of direct URL/token parameters
- Added comprehensive file upload service with presigned URL support and chunked uploads
- Updated existing tests and added extensive test coverage for the new upload functionality
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_service.py |
Refactored existing tests to use MetaData objects and added comprehensive test suite for FileUploadService |
pyproject.toml |
Updated version and added type stubs for requests and PyYAML |
mkdocs.yml |
Added service documentation reference |
docs/reference/service.md |
Added comprehensive documentation for service API including file upload methods |
csfunctions/service/numgen.py |
Simplified by removing duplicate classes and importing from base module |
csfunctions/service/file_upload_schemas.py |
Added Pydantic models for file upload request/response schemas |
csfunctions/service/file_upload.py |
Implemented FileUploadService with chunked upload, error handling, and abort functionality |
csfunctions/service/base.py |
Created base service class with metadata-based initialization and enhanced error handling |
csfunctions/service/__init__.py |
Added service module initialization with proper exports |
csfunctions/handler.py |
Updated to use metadata-based service initialization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
conlwi
reviewed
Aug 26, 2025
conlwi
approved these changes
Aug 26, 2025
albertsj
reviewed
Aug 27, 2025
Co-authored-by: Julian Alberts <julian.alberts@contact-software.com>
Co-authored-by: Julian Alberts <julian.alberts@contact-software.com>
albertsj
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add methods for uploading files to CIM Database Cloud via the Functions Access Service.