Allow installation of psalm 6, Drop PHP 8.0 support#4
Conversation
…uppresses which are not relevant for the test case. Add some unused supresses for the plugin itself. Update deps.
cspray
left a comment
cspray
left a comment
There was a problem hiding this comment.
Thank you for submitting this change! I had one minor request, once it gets updated I will merge this in and cut a new release.
src/AllowInheritance.php
Outdated
|
|
||
| use Attribute; | ||
|
|
||
| /** @psalm-suppress UnusedClass */ |
There was a problem hiding this comment.
I actually believe this should be annotated as @api. This communicates the class is part of the public facing API used by installers of this lib.
Edit: And, of course, getting the build to go green :)
There was a problem hiding this comment.
Ah, didnt know this annotation exist.
Regarding failing build: would drop PHP 8.0 then :)
DanielBadura
changed the title
|
@cspray could you again have a look on this patch? |
|
@DanielBadura Sorry for the delay. I will review this today. Thanks! |
|
Thank you very much for your contribution! I'll cut a new major release soon to enable using Psalm 6. |
|
Thanks! I don't think you would need a new major version for this since the API for the user did not change. But the choice is yours :D |
2 participants
I removed the stub logic alltogether since it was not used, added some supresses to satify pslam as it seems this is the way to go here, otherwise i would have created a baseline for them.