Fix wstring argument type definitions in SyscallToSCDG#45
Open
Thib-fkr wants to merge 2 commits intocsvl:productionfrom
Open
Fix wstring argument type definitions in SyscallToSCDG#45Thib-fkr wants to merge 2 commits intocsvl:productionfrom
Thib-fkr wants to merge 2 commits intocsvl:productionfrom
Conversation
Thib-fkr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds type definitions which enable the SyscallToSCDG module to recognize wide string parameters used in syscalls such as
_wcsicmp.Without such type definition, arguments appear as unsigned integers (pointers) in the SCDG.
With them, the module tries (and succeed as far as my tests went) to resolve the wide strings and put the result in the SCDG.