Skip to content

Repetitive Dataset and DataLoader Creation in PyTorch version #96

Description

@sptom

Hi there!
My question is - is there any particular reason for creating the entire dataset and dataloader every epoch from scratch? This is done in the PyTorch version, in the main_train file:

image

As I see it - it doesn't add anything because the addition of the noise is done in the 'get_item' function, so the noise is randomized any way a batch is drawn anyway. So this creation takes time from computing the same dataloader each epoch, without adding value.

Am I missing something? Please correct me if I'm wrong

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions