Remove proc_macro_hack, prepare for rust 2021, and appease clippy#9
Open
LLBlumire wants to merge 6 commits intoct-austin:masterfrom
Open
Remove proc_macro_hack, prepare for rust 2021, and appease clippy#9LLBlumire wants to merge 6 commits intoct-austin:masterfrom
LLBlumire wants to merge 6 commits intoct-austin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proc_macro_hack causes issues with rust-analyser and has been deprecated anyway .
I wanted to remove the hack, so have vendored it and thus needed to make some other changes to get
cargo checkandcargo clippypassing.This change also enables refactoring to not be a workspace, but instead a regular old crate, which also lets us use the
examplesdirectory instead of having a specific demo workspaceI can break these out into separate pull requests if you want