Skip to content

Publish jmsfx-battleorder, and correct what CLAUDE.md gets wrong - #145

Merged
ctgnz merged 1 commit into
masterfrom
chore/144-release-2.0.0
Sep 30, 2026
Merged

ctgnz merged 1 commit into
masterfrom
chore/144-release-2.0.0

Conversation

@ctgnz

@ctgnz ctgnz commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Release preparation for 2.0.0, whose milestone is now clear — 20 issues closed, #82 among them. Part of #144.

jmsfx-battleorder publishes

It was excluded from Central "until it can draw" — it carried no SVG fragments of its own, so it compiled and registered itself as an IconLibrary that rendered nothing, which is not a thing to put somewhere a release cannot be withdrawn from.

The exclusion named its own trigger: comes off this list once jmsfx#82 … settles how a library gets its fragments. That is settled. Fragments are injected into the generated code, so this library draws jmsfx-standard's through the tree it extends (#133), with no second IconLibrary on the classpath. It reports 0 classpath fallbacks across 17,513 load calls, and ServiceBranchFrameTest renders the actual branch colours.

So leaving it out would now be by default rather than by decision — which is exactly what that comment existed to prevent. The comment is rewritten to say why it publishes, rather than left stating a condition that has expired.

Five artifacts go to Central: jmsfx-parent, jmsfx-core, jmsfx-standard, jmsfx-historical, jmsfx-battleorder. Creator, editor, server and the generator stay unpublished — applications and build tooling, not things anyone resolves.

CLAUDE.md had four claims that stopped being true during the epic

This matters more than most stale prose, because it is the file that steers work here.

claim reality
ModelComparator is "bound to verify" Not since #137 — every extension is an overlay composed onto its base, so the superset property holds by construction and there is nothing for a build-time check to catch
jmsfx-historical "still carries a complete model" #137 reduced it to its additions
overlayModel: true distinguishes an overlay, "which only jmsfx-battleorder is" The field no longer exists. isOverlay() is baseLibrary != null — once historical became an overlay too, there was no distinction left to carry
historical keeps "314 additions" 356, with the extinct status and the bicycle drawing

Two facts added that later work needs: model elements nest their scalars under details: with the flow style on the record rather than the class, and the fallback count is asserted on every build rather than something to go and measure.

The last two hallux mentions

Neither was in code or build config — the rename to jmsfx-historical was clean, and no module, package, artifact or config still says hallux. But .gitattributes described keeping fragments "byte-comparable against hallux's copies", and those copies go away once historical is on Central, so the comment now says what the setting actually buys.

Verification

BUILD SUCCESS on -Pstandard, -Phistorical and -Pbattleorder, and the release profile builds clean with signing and javadoc skipped.

No version bump here — that is the next step on #144, and it needs -DprocessAllModules=true or twelve of the thirteen poms stay on 2.0.0-SNAPSHOT.

🤖 Generated with Claude Code

Release preparation for 2.0.0, whose milestone is now clear.

jmsfx-battleorder comes off excludeArtifacts. It was held out "until it can
draw" - it carried no SVG fragments of its own and so registered itself as an
IconLibrary that rendered nothing, which is not a thing to put on Central, where
a release cannot be withdrawn. The exclusion named its own trigger: once #82
settles how a library gets its fragments. That is settled - they are injected
into the generated code, so this one draws jmsfx-standard's through the tree it
extends (#133) with no second IconLibrary on the classpath. It reports 0
classpath fallbacks across 17,513 load calls and ServiceBranchFrameTest renders
the branch colours, so leaving it out would now be by default rather than by
decision, which is what that comment existed to prevent. Five artifacts publish:
jmsfx-parent, jmsfx-core, jmsfx-standard, jmsfx-historical, jmsfx-battleorder.

CLAUDE.md had four claims about the build that stopped being true during the #82
epic, which matters more than most stale prose because it is what steers work
here:

  - ModelComparator is described as bound to `verify`. It is not, since #137:
    every extension is an overlay composed onto its base, so the superset
    property holds by construction and there is nothing for a build-time check
    to catch.
  - jmsfx-historical is described as still carrying a complete model. #137
    reduced it to its additions.
  - `overlayModel: true` is documented as the flag that distinguishes an overlay,
    and as something only jmsfx-battleorder sets. The field no longer exists -
    isOverlay() is `baseLibrary != null` - because once historical became an
    overlay too there was no distinction left to carry.
  - historical's fragment count was 314; it is 356, with the extinct status and
    the bicycle drawing added.

Two facts added that later work needs: model elements nest their scalars under
`details:`, with the flow style on the record rather than the class; and the
classpath fallback count is asserted on every build rather than something to go
and measure.

The two remaining `hallux` mentions go with them. Neither was in code or build
config - the rename to jmsfx-historical was clean - but .gitattributes described
keeping fragments "byte-comparable against hallux's copies", and those copies go
away once historical is on Central.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ctgnz
ctgnz merged commit bd3b6af into master Sep 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant