Skip to content

Fix 2 PEP issues#69

Merged
cigamit merged 1 commit into
mainfrom
pep-e306
Jun 26, 2026
Merged

Fix 2 PEP issues#69
cigamit merged 1 commit into
mainfrom
pep-e306

Conversation

@cigamit

@cigamit cigamit commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

ERROR: Found 2 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/job_template.py:610:13: E306: expected 1 blank line before a nested definition, found 0
ERROR: plugins/modules/workflow_job_template.py:955:13: E306: expected 1 blank line before a nested definition, found 0

@cigamit cigamit requested a review from TheWitness June 26, 2026 20:29
@cigamit cigamit self-assigned this Jun 26, 2026
Copilot AI review requested due to automatic review settings June 26, 2026 20:29
@cigamit cigamit added the bug Something isn't working label Jun 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Resolves flake8/pep8 E306 violations by adding the required blank line before nested function definitions inside main() in the affected modules.

Changes:

  • Inserted a blank line before the nested on_change() definition in job_template.py.
  • Inserted a blank line before the nested on_change() definition in workflow_job_template.py.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
plugins/modules/job_template.py Adds the required blank line before a nested function definition to satisfy E306.
plugins/modules/workflow_job_template.py Adds the required blank line before a nested function definition to satisfy E306.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cigamit cigamit merged commit fa5ab51 into main Jun 26, 2026
13 checks passed
@cigamit cigamit deleted the pep-e306 branch June 26, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

3 participants