Skip to content

Update linting config and PR template #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blaipr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update linting config and PR template #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4eb4fcc
Update linting configuration and PR template
blaipr Jun 27, 2026
f10c57f
Add mock_roles for filetree_read to fix syntax-check error
blaipr Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .ansible-lint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@

offline: true

# Mock collection roles so ansible-lint doesn't error on unresolved FQCNs
mock_roles:
- ctrliq.ascender.filetree_read

# Mock collection modules so ansible-lint doesn't error on unresolved FQCNs
mock_modules:
- ctrliq.ascender.ad_hoc_command
Expand Down Expand Up @@ -73,3 +77,4 @@ warn_list:
- no-changed-when
- command-instead-of-shell
- risky-shell-pipe
- args[module]
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@

## Checklist
- [ ] Sanity tests pass (`ansible-test sanity`)
- [ ] Linting passes (`flake8`, `yamllint`)
- [ ] Linting passes (`ruff`, `yamllint`, `ansible-lint`)
- [ ] Changelog fragment added (if user-facing change)
- [ ] Documentation updated (if applicable)
5 changes: 5 additions & 0 deletions .yamllint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,8 @@ rules:
allow-non-breakable-inline-mappings: true
truthy:
allowed-values: ['true', 'false', 'yes', 'no']
comments:
min-spaces-from-content: 1
octal-values:
forbid-implicit-octal: true
forbid-explicit-octal: true