Remove tower_* aliases from controller_export_diff#84
Open
blaipr wants to merge 2 commits into
Open
Conversation
The controller_export_diff module defined tower_* parameter aliases without deprecated_aliases, inconsistent with all other modules that use the shared AUTH_ARGSPEC deprecation targeting v26.0.0. Add matching deprecated_aliases entries so users get proper deprecation warnings.
Ascender has no Tower heritage, so these aliases serve no purpose. Remove them entirely rather than deprecating.
blaipr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tower_*parameter aliases (tower_host,tower_username,tower_password,tower_oauthtoken,tower_verify_ssl,tower_config_file) fromcontroller_export_diff.pyTest plan
ansible-test sanitypassesruff check plugins/passescontroller_*parameters