Skip to content

Simplify is_job_done() to a single return statement #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blaipr wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −4
Open

Simplify is_job_done() to a single return statement #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions plugins/module_utils/controller_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,10 +1036,7 @@ def logout(self):
self.warn(f'Failed to release token {self.oauth_token_id}: {e}')

def is_job_done(self, job_status):
if job_status in ['new', 'pending', 'waiting', 'running']:
return False
else:
return True
return job_status not in ['new', 'pending', 'waiting', 'running']

def wait_on_url(self, url, object_name, object_type, timeout=30, interval=2):
# Grab our start time to compare against for the timeout
Expand Down