Remove dead block/rescue logic in filetree_create role#86
Open
blaipr wants to merge 1 commit into
Open
Conversation
The block/rescue structure checked for ctrliq.ascender in both paths, making the rescue branch unreachable. The awx_awx_collection_installed variable was a legacy artifact. Simplify to a straightforward check-then-set flow that directly sets controller_api_plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roles/filetree_create/tasks/main.ymlthat checked for the same collection (ctrliq.ascender) as the blockawx_awx_collection_installedvariable namecontroller_api_pluginThe block and rescue branches both checked for
ctrliq.ascender, so the conditional that chose between them always resolved to the same value. The entire rescue path was dead code.Test plan
ansible-lintpassesfiletree_createrole still correctly detects the collection and setscontroller_api_plugin