Remove tower_* aliases and references from auth layer#91
Open
blaipr wants to merge 1 commit into
Open
Conversation
Ascender has no Tower heritage. Remove tower_* parameter aliases, TOWER_* environment variable fallbacks, and tower_cli.cfg config file references from the shared auth infrastructure. Rename config file to controller_cli.cfg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tower_*parameter aliases anddeprecated_aliasesfromAUTH_ARGSPECincontroller_api.pyTOWER_*environment variable fallbacks from all auth parameterstower_cli.cfgtocontroller_cli.cfg(class attribute,/etc/path, and doc references)tower_*aliases and deprecation notices from both doc fragments (auth.py,auth_plugin.py)TOWER_*env var entries from inventory/lookup plugin doc fragment (auth_plugin.py)Ascender is its own product with no Tower lineage, so these aliases and fallbacks serve no purpose.
Test plan
ruff check plugins/passesansible-test sanitypassescontroller_*parameters andCONTROLLER_*env varscontroller_cli.cfgpaths