Skip to content

Fix offline install missing community.general collection #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ssimpson89 wants to merge 1 commit into from
Closed

Fix offline install missing community.general collection #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ if [ $? -ne 1 ]; then
ansible-galaxy collection install $(dirname $0)/offline/collections/awx-awx-22.3.0.tar.gz
ansible-galaxy collection install $(dirname $0)/offline/collections/kubernetes-core-2.4.0.tar.gz
ansible-galaxy collection install $(dirname $0)/offline/collections/amazon-aws-6.5.0.tar.gz
ansible-galaxy collection install $(dirname $0)/offline/collections/community-general-8.3.0.tar.gz
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new community.general install line may never run in environments where the other checked collections are present but community.general is missing, because check_collections() doesn’t currently verify any community.general plugin/module. Consider updating the detection logic to include a check for the community.general.collection_version lookup (or another community.general component), so missing community.general reliably triggers the install block.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The offline collection install commands use an unquoted $(dirname $0) path. If the script path contains spaces or glob characters, this will break and can cause ansible-galaxy to receive a truncated path. Quote the dirname expansion (and ideally compute a SCRIPT_DIR once) before building these file paths.

Copilot uses AI. Check for mistakes.
else
ansible-galaxy install -r collections/requirements.yml
fi
Expand Down
Loading