Remove conditional check for HTTPS in ledger deployment template#185
Open
ssimpson89 wants to merge 1 commit intoctrliq:mainfrom
Open
Remove conditional check for HTTPS in ledger deployment template#185ssimpson89 wants to merge 1 commit intoctrliq:mainfrom
ssimpson89 wants to merge 1 commit intoctrliq:mainfrom
Conversation
Signed-off-by: Stephen Simpson <ssimpson89@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an extraneous/unmatched Jinja conditional at the top of the RKE2 ledger deployment template that was blocking ledger deployment when rendered.
Changes:
- Removed the leading
{% if k8s_lb_protocol == 'https' %}line that wrapped the whole template without a matching{% endif %}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was preventing deployment of ledger in rke2. Either this line needs to be removed or an endif needs to be added