Skip to content

chore: add kafka config options #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityachoudhari26 merged 2 commits into from
Feb 10, 2026
Merged

chore: add kafka config options #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c006085
chore: add kafka config options
adityachoudhari26 Feb 10, 2026
5c4fd77
fix notes.txt
adityachoudhari26 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/ctrlplane/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: ctrlplane
description: Ctrlplane Helm chart for Kubernetes
type: application
version: 0.9.3
version: 0.10.0
appVersion: "1.0.0"

maintainers:
Expand Down
6 changes: 5 additions & 1 deletion charts/ctrlplane/charts/workspace-engine/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ spec:
protocol: TCP
env:
- name: KAFKA_BROKERS
value: {{ .Values.global.kafkaBrokers | quote }}
value: {{ .Values.global.kafka.brokers | quote }}
- name: KAFKA_GROUP_ID
value: {{ .Values.global.kafka.groupId | quote }}
- name: KAFKA_TOPIC
value: {{ .Values.global.kafka.topic | quote }}

- name: POD_NAME
valueFrom:
Expand Down
2 changes: 2 additions & 0 deletions charts/ctrlplane/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,13 @@
{{- else if ne .Values.global.integrations.github.bot.clientSecret "" }}
⚠ GitHub bot configured directly in values
{{- end }}
{{- if .Values.global.integrations.azure }}
{{- if include "ctrlplane.isValueFrom" .Values.global.integrations.azure.appClientSecret }}
✓ Azure app configured via secret reference
{{- else if ne .Values.global.integrations.azure.appClientSecret "" }}
⚠ Azure app configured directly in values
{{- end }}
{{- end }}

3. Using valueFrom pattern for secrets:

Expand Down
5 changes: 4 additions & 1 deletion charts/ctrlplane/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ global:
port: "5432"
database: "ctrlplane"

kafkaBrokers: localhost:9092
kafka:
brokers: localhost:9092
groupId: workspace-engine
topic: workspace-events
Comment on lines +62 to +65
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Breaking change: existing overrides of global.kafkaBrokers will silently stop working.

Users who have global.kafkaBrokers in their custom values.yaml or --set flags will not get an error — the old key will simply be ignored, and the new defaults will apply. Consider documenting this migration in the chart's changelog or README, and optionally adding a validation template that fails with a helpful message if the old key is still set.

🤖 Prompt for AI Agents 
In `@charts/ctrlplane/values.yaml` around lines 62 - 65, The chart introduced a
breaking key rename so existing overrides of global.kafkaBrokers will be
ignored; update the chart to detect and handle the old key by adding a
validation or compatibility layer: add a templated check (e.g., in
templates/_helpers.tpl or a new templates/validation.yaml) that fails
install/upgrade with a clear error if global.kafkaBrokers is set, or populate
kafka.brokers from global.kafkaBrokers when present to preserve backward
compatibility, and document the change in the README/CHANGELOG; reference the
values keys global.kafkaBrokers and kafka.brokers and the values.yaml defaults
when implementing this.


integrations:
github:
Expand Down