Skip to content

fix(ctrlc-sync): missing provider#28

Merged
dacbd merged 1 commit intomainfrom
dacbd/ctrlc-sync-provider
Feb 14, 2026
Merged

fix(ctrlc-sync): missing provider#28
dacbd merged 1 commit intomainfrom
dacbd/ctrlc-sync-provider

Conversation

@dacbd
Copy link
Copy Markdown
Collaborator

@dacbd dacbd commented Feb 14, 2026

Summary by CodeRabbit

  • New Features

    • Added configurable provider option for the Ctrl-C sync service, allowing selection of the sync provider.
  • Chores

    • Bumped Helm chart version to 0.1.1.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 14, 2026

📝 Walkthrough

Walkthrough

This PR updates the ctrlc-sync Helm chart to version 0.1.1 by introducing provider configuration support. The changes include incrementing the chart version, adding a --provider command-line argument to the cronjob container template, and adding a corresponding provider configuration field to values.yaml.

Changes

Cohort / File(s) Summary
Provider Configuration Support
charts/ctrlc-sync/Chart.yaml, charts/ctrlc-sync/templates/cronjob.yaml, charts/ctrlc-sync/values.yaml
Chart version bumped to 0.1.1. Added --provider={{ .Values.ctrlc.provider }} flag to cronjob container arguments. New ctrlc.provider field added to values.yaml with empty string default.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Initial ctrlc-sync helm chart #27: Directly related as the base PR introducing the ctrlc-sync chart files that are now being updated with provider configuration support.

Suggested reviewers

  • jsbroks
  • adityachoudhari26
  • zacharyblasczyk

Poem

🐰 A provider now springs to life,
From values passed, without strife,
A tiny bump, version so neat,
Makes the config complete! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding a missing provider configuration to the ctrlc-sync Helm chart, which is reflected across the version bump, template updates, and values additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dacbd/ctrlc-sync-provider

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@charts/ctrlc-sync/templates/cronjob.yaml`:
- Line 68: The template currently emits the literal flag --provider={{
.Values.ctrlc.provider }} even when .Values.ctrlc.provider is empty; change the
args entry that builds the cronjob command to conditionally include the provider
flag only when .Values.ctrlc.provider is non-empty (use the same {{- if
.Values.ctrlc.provider }} ... {{- end }} pattern used elsewhere) so the args
array contains either the flag with a value or omits it entirely; update the
args line referencing .Values.ctrlc.provider and the --provider flag accordingly
to preserve valid YAML/array formatting.

imagePullPolicy: {{ .Values.image.pullPolicy }}
command: ["ctrlc"]
args: ["sync", "kubernetes"]
args: ["sync", "kubernetes", "--provider={{ .Values.ctrlc.provider }}"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

--provider is passed unconditionally, even when empty.

The default value for ctrlc.provider is "", so this renders as --provider= which may cause the CLI to fail or behave unexpectedly. Other optional fields in this template (e.g., timeZone, startingDeadlineSeconds) are guarded with {{- if }} — this should follow the same pattern.

Proposed fix: conditionally include the provider flag
-              args: ["sync", "kubernetes", "--provider={{ .Values.ctrlc.provider }}"]
+              args:
+                - "sync"
+                - "kubernetes"
+                {{- if .Values.ctrlc.provider }}
+                - "--provider={{ .Values.ctrlc.provider }}"
+                {{- end }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
args: ["sync", "kubernetes", "--provider={{ .Values.ctrlc.provider }}"]
args:
- "sync"
- "kubernetes"
{{- if .Values.ctrlc.provider }}
- "--provider={{ .Values.ctrlc.provider }}"
{{- end }}
🤖 Prompt for AI Agents
In `@charts/ctrlc-sync/templates/cronjob.yaml` at line 68, The template currently
emits the literal flag --provider={{ .Values.ctrlc.provider }} even when
.Values.ctrlc.provider is empty; change the args entry that builds the cronjob
command to conditionally include the provider flag only when
.Values.ctrlc.provider is non-empty (use the same {{- if .Values.ctrlc.provider
}} ... {{- end }} pattern used elsewhere) so the args array contains either the
flag with a value or omits it entirely; update the args line referencing
.Values.ctrlc.provider and the --provider flag accordingly to preserve valid
YAML/array formatting.

@dacbd dacbd merged commit a5519c3 into main Feb 14, 2026
4 checks passed
@dacbd dacbd deleted the dacbd/ctrlc-sync-provider branch February 14, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant