Skip to content

feat: editable Marker Board widget with custom title, message, trunca… #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Muskankr wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

feat: editable Marker Board widget with custom title, message, trunca… #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/widgets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1752,6 +1752,11 @@ function renderSegments(segments, defaultColor, fontSize, yCoord, className, mar
};
}

function truncate(str, limit=200) {
if (!str) return '';
return str.length > limit ? str.slice(0, limit) + '…' : str;
}

async function renderMarker(p) {
const isCard = p.markerStyle === 'card';
const W = 600;
Expand Down Expand Up @@ -1797,8 +1802,10 @@ async function renderMarker(p) {

if (!isCard) {
// BANNER LAYOUT
const titleText = p.label || p.name || 'HELLO, WORLD!';
const subText = p.bio || p.role || 'Highlighter & sketchbook theme.';
const titleText = escXml(truncate(p.markerTitle || p.label || p.name || 'HELLO, WORLD!', 50));
let subText = escXml(truncate(p.markerMessage || p.bio || p.role || 'Highlighter & sketchbook theme.', p.markerLimit || 200));
subText = subText.replace(/<mark[^>]*>/gi, '').replace(/<\/mark>/gi, '');


const titleRender = renderSegmentedText(titleText, col, 26, 81, 'm-title', marginX, 30);
const subRender = renderSegmentedText(subText, col, 14, 123, 'm-subtitle', marginX, 30);
Expand Down Expand Up @@ -1851,7 +1858,9 @@ async function renderMarker(p) {
return skillIcon(s, skillsX + colIdx * (iconSize + gap), skillsY, iconSize);
}).join('');

const nameText = p.name || 'Your Name';
const nameText = escXml(truncate(p.markerTitle || p.name || 'Your Name', 50));
const bio = (p.markerMessage || p.bio || '').trim();


const nameRender = renderSegmentedText(nameText, col, 28, 81, 'm-title', marginX, 25);
const bioLine1Render = bioLinesSegments[0] ? renderSegments(bioLinesSegments[0], col, 12, 122, 'm-body', marginX, 25) : { highlights: '', text: '' };
Expand Down
2 changes: 1 addition & 1 deletion tests/widgets.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,4 +220,4 @@ describe('renderWidget', () => {
expect(xml).toContain('GRADUATION');
});
});

});