Render single $ literally instead of as inline math - #514
Merged
Conversation
remark-math treats single $...$ as inline KaTeX, so currency like "$271,677.37 ... $272,748.58" was wrongly rendered as a formula. Disable single-dollar text math (singleDollarTextMath:false); display math via $$…$$ still renders. Add regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remark-mathwas treating a single$…$as inline KaTeX. Sentences with currency like "Monthly revenue increased from $271,677.37 in January to $272,748.58 in February" were mis-rendered as a formula.singleDollarTextMath: false) inMarkdownWithCitations.tsx. Display math via$$…$$still renders..katexmarkup), and$$…$$still renders as KaTeX.Test plan
pnpm --filter web test MarkdownWithCitations→ 5 passed.katexspan for$271,677.37 … $272,748.58and that the amounts survive as literal text$$E=mc^2$$still renders as KaTeX🤖 Generated with WorkBuddy