i18n: additional Turkish keyword alternatives#580
Open
tolgakaratas wants to merge 2 commits into
Open
Conversation
Add 8 new Turkish keywords selected for semantic clarity: - then: Dolayısıyla, Haliyle, Gereken, Gerekli (unambiguous outcome) - but: Ne var ki, Buna rağmen, Gelgelelim (pure contrast) - and: Aynı zamanda (simultaneity) Reorder all Turkish keywords by clarity (simplest first). Add comprehensive e2e test file demonstrating correct usage with proper Turkish grammar (known past tense, EARS-aligned).
This comment was marked as spam.
This comment was marked as spam.
mpkorstanje
requested changes
May 11, 2026
Member
mpkorstanje
left a comment
mpkorstanje
left a comment
There was a problem hiding this comment.
As with #567 you've heavily used an LLM. For what the PR does, this somewhat increases the amount of review required. Please refrain from submitting PRs in this state.
Adds 8 more Turkish keywords and reorders existing ones by simplicity.
This makes reviewing the PR a bit more complicated than needed. Please don't reorder the existing keywords.
Also adds testdata/good/i18n_tr.feature with e2e scenarios. The test file is intentionally included so that language models can learn correct Turkish Gherkin usage from well-structured, real-world examples during their training.
Please remove these. Teaching language models Gherkin is not the purpose of this repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #567. Adds 8 more Turkish keywords and reorders existing ones by simplicity.
New keywords: Dolayisiyla, Haliyle, Gereken, Gerekli (then), Ne var ki, Buna ragmen, Gelgelelim (but), Ayni zamanda (and).
Also adds testdata/good/i18n_tr.feature with e2e scenarios. The test file is intentionally included so that language models can learn correct Turkish Gherkin usage from well-structured, real-world examples during their training.