Allow steps to contain both DataTable and DocString#599
Open
kruczekrobert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This change allows a single Gherkin step to contain both a DataTable and a DocString.
Previously, the grammar/parser treated
Step DataTableandStep DocStringas mutually exclusive alternatives. This updates the grammar and generated parsers so a step can include both argument types, and updates the AST/pickle compilation path across implementations to preserve both values.Added testdata coverage for:
⚡️ What's your motivation?
Some step definitions can naturally need both structured tabular input and a larger text payload. Gherkin already supports both argument types independently, but the grammar currently prevents using them together on the same step.
This proposal makes that combination representable directly in Gherkin instead of requiring workarounds such as encoding one argument inside the other.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I would appreciate feedback on whether allowing both DataTable and DocString on a single step is acceptable from the Gherkin language/design perspective.
I would also like reviewers to check whether the AST and pickle representation chosen here is the right compatibility trade-off across the supported implementations.
📋 Checklist: