feat: support optional arguments for int/uint/float types#747
Open
chengxilo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This would support int/uint/float pointer as parameter in step functions
⚡️ What's your motivation?
I'm a contributor to Apache iggy, I'm planning to add a BDD test scenario for it.
Here is the use case I have:
I have the following steps for different sceanarios.
Currently, this is what I'm doing
I hate to do parse the string to uint/int when writing my test, so I hope I can support optional parameter using pointer in godog.
Here is what my function would be like if this feature is implemented.
I don't want to
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
I'm not sure if this would be accepted, so I will delay adding the document (since I hate writing), also the CHANGELOG.md
This text was originally generated from a template, then edited by hand. You can modify the template here.