Skip to content

Apply improvements from go fix - #50

Open
tianon wants to merge 1 commit into
cue-labs:mainfrom
tianon:go-fix
Open

Apply improvements from go fix#50
tianon wants to merge 1 commit into
cue-labs:mainfrom
tianon:go-fix

Conversation

@tianon

@tianon tianon commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

These all seem pretty uncontroversial. 👀

These all seem pretty uncontroversial. 👀

Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
@tianon
tianon requested a review from porcuepine as a code owner March 20, 2026 22:17
@mvdan

mvdan commented Mar 20, 2026

Copy link
Copy Markdown
Member

Thanks! Agreed this is fine. Could you send this change on Gerrit so we could merge it?

@tianon

tianon commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

I guess I can give it a go, although it's not linked on either https://github.com/cue-labs/oci or https://github.com/cue-labs/oci/blob/3adeb866381942f8fcc777812752a5a9e8869b68/CONTRIBUTING.md 😅

Is there a good reference somewhere?

(FWIW, I find Gerrit to be extremely hostile UX; perhaps that's part of the point, but I figured I'd note it 🫣 🖤)

@mvdan

mvdan commented Mar 20, 2026

Copy link
Copy Markdown
Member

Oh it's https://gerrithub.io; https://github.com/cue-lang/cue/blob/master/CONTRIBUTING.md might be a bit more complete. Just swap cue-lang/cue for cue-labs/oci. If you can't figure it out, no problem, I'll import to Gerrit on my side.

@tianon

tianon commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

I don't see a way I can log into that without giving it push access to repositories for which I can't reasonably authorize that (which is admittedly a failing of GitHub's auth), so yeah, it might be best for you to import it instead 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants