Apply improvements from go fix - #50
Conversation
These all seem pretty uncontroversial. 👀 Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
|
Thanks! Agreed this is fine. Could you send this change on Gerrit so we could merge it? |
|
I guess I can give it a go, although it's not linked on either https://github.com/cue-labs/oci or https://github.com/cue-labs/oci/blob/3adeb866381942f8fcc777812752a5a9e8869b68/CONTRIBUTING.md 😅 Is there a good reference somewhere? (FWIW, I find Gerrit to be extremely hostile UX; perhaps that's part of the point, but I figured I'd note it 🫣 🖤) |
|
Oh it's https://gerrithub.io; https://github.com/cue-lang/cue/blob/master/CONTRIBUTING.md might be a bit more complete. Just swap |
|
I don't see a way I can log into that without giving it push access to repositories for which I can't reasonably authorize that (which is admittedly a failing of GitHub's auth), so yeah, it might be best for you to import it instead 😅 |
These all seem pretty uncontroversial. 👀