fix(web): root metadata carries the brand positioning - #272
Merged
Conversation
…st, matched card descriptions Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ooter, signin) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/src/app/layout.tsx: title now matches the home og/twitter card ("Expendit — See every naira. File every tax.") instead of the bare "Expendit", and the fleet-fallbackdescriptiondrops the placeholder "Expense tracker App" for the ratified tagline "See every naira. File every tax." (matchesweb/scripts/generate-brand-assets.mjs'sexpendit.tagline, already used for the shipped og-image, its alt text, and the home hero H1).web/src/app/manifest.ts:descriptionmatches the fix above, per the file's own doc comment ("Identity mirrors the root layout metadata").web/src/app/page.tsx:openGraph.descriptionandtwitter.descriptionpreviously carried two different strings — unified into a singleCARD_DESCRIPTIONconstant (mirroring the single-constant pattern used in apparule/upstat's home metadata) so the cards can't drift again.web/e2e/seo.spec.ts(fleet-shared, byte-identical across repos) only asserts generic shapes (manifest name contains the product name, canonical/og-image/icons resolve) — no hardcoded copy there, so it needed no changes. No other test hardcodes the old placeholder strings.Note:
docs/pages.md's A2 row still lists the hero H1 as "Financial intelligence for modern growth", which is stale — the shippedHeroSection.tsx,web/e2e/home.spec.ts(locked),opengraph-image.alt.txt, andgenerate-brand-assets.mjsall agree on "See every naira. File every tax." Treated code as ground truth here rather than reverting live copy to the stale doc cell; flagging for a separate docs-currency pass.Test plan
cd web && npm run lint— clean (prettier, eslint, check:boundaries)cd web && npm test— 95 files / 486 tests passedcd web && npm run typecheck— clean🤖 Generated with Claude Code