Skip to content

Conversation

@cupoftea4
Copy link
Owner

No description provided.

@cupoftea4 cupoftea4 requested a review from Copilot September 9, 2025 21:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR comments out the semestrduration: "1" parameter in two API calls within the LPNU data fetching utility. The change removes this parameter from both the lecturer timetable fetching and the regular timetable fetching functions.

  • Commented out semestrduration parameter in lecturer timetable API calls
  • Commented out semestrduration parameter in regular timetable API calls
Comments suppressed due to low confidence (1)

src/utils/data/LPNUData.ts:1

  • The semestrduration parameter is still being used in the getPartialTimetable method while it's been commented out in other methods. This inconsistency could lead to confusion about when this parameter should or shouldn't be used. Consider either commenting it out here as well or documenting why it's still needed in this specific case.
import type { LPNUTimetableType, TimetableType } from "@/types/timetable";

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cupoftea4 cupoftea4 requested a review from Aler1x September 9, 2025 21:25
Copy link
Collaborator

@Aler1x Aler1x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why, NULP?

@cupoftea4 cupoftea4 merged commit 0cb1b26 into master Sep 9, 2025
2 checks passed
@railway-app railway-app bot temporarily deployed to timetable (bot / production) September 9, 2025 21:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants