Also merge spanners when calling stream.Score.partsToVoices#1796
Also merge spanners when calling stream.Score.partsToVoices#1796mscuthbert merged 4 commits intocuthbertLab:masterfrom
Conversation
|
Hi guang-yng -- thanks for the contribution -- I'm looking forward to being able to merge this. Make sure that What about spanners within the part's measures? Should we be collecting them? In which case might be the better loop variable. |
|
Hi @mscuthbert , thanks for the quick review! I’ll make the fixes and add test cases. Also, do you think we should merge |
|
For now, one PR = one feature. We can do dynamics after you have a successful merge etc. |
|
Hi @mscuthbert, just checking in—would it be okay to merge this PR now? |
|
Thanks for the bump! |
What does this PR do?
When calling
stream.Score.partsToVoices, onlynotesAndRestsare merged into the new part. We can also merge the spanners from those parts into the new one.