Skip to content

Update of property assignment syntax for Lilypond conversion (issue #1791)#1800

Merged
mscuthbert merged 4 commits intocuthbertLab:masterfrom
jeremy9959:jeremy9959-1791
Aug 8, 2025
Merged

Update of property assignment syntax for Lilypond conversion (issue #1791)#1800
mscuthbert merged 4 commits intocuthbertLab:masterfrom
jeremy9959:jeremy9959-1791

Conversation

@jeremy9959
Copy link
Contributor

The property assignment syntax for lilypond has been updated, so that instead of

\override Property #'Attribute = value

we have

\override Property.Attribute = value

This responds to issue #1791

@coveralls
Copy link

coveralls commented Jun 23, 2025

Coverage Status

coverage: 92.998%. remained the same
when pulling ed9f50f on jeremy9959:jeremy9959-1791
into eb5a88f on cuthbertLab:master.

@jeremy9959
Copy link
Contributor Author

The flake errors refer to "" vs '' and most have nothing to do with changes I made, so I hesitate to get involved in that.

@mscuthbert mscuthbert closed this Aug 8, 2025
@mscuthbert mscuthbert reopened this Aug 8, 2025
@mscuthbert
Copy link
Member

closing and reopening to get a clear flake sign.

@mscuthbert
Copy link
Member

Hi -- those flake things were "caused" by you -- I'll do a quick fix.

When you modified the Rest #'Property to Rest.Property you removed the single-quote within double-quotes. Therefore there was no longer a reason why we should use double quotes. Easy fix for me as penance for letting this slip.

@mscuthbert mscuthbert merged commit 2554e64 into cuthbertLab:master Aug 8, 2025
7 checks passed
@mscuthbert
Copy link
Member

thanks!

@jeremy9959
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants