Skip to content

Fix use-after-free in Connection.read_fls binding (keep_alive) #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
z0mz0m wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix use-after-free in Connection.read_fls binding (keep_alive) #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/bindings/connection_binding.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ void bind_connection(py::module_& m) {
&fastlanes::Connection::read_fls,
py::arg("dir_path"),
"Read a .fls file and return a FastLanes Reader",
py::return_value_policy::move)
py::return_value_policy::move,
// TableReader holds `Connection&`; without this the connection can be
// collected while the reader is still alive (e.g. the README's
// `connect().read_fls(p).to_csv(q)`), giving a use-after-free.
py::keep_alive<0, 1>())
.def("inline_footer",
&fastlanes::Connection::inline_footer,
"Enable footer inlining",
Expand Down