Handle filterless exact sum overflow - #26
Open
ila wants to merge 3 commits into
Open
Conversation
ila
force-pushed
the
codex/filterless-exact-overflow
branch
from
September 2, 2026 17:46
2191711 to
fb108b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for reviewing.
Summary
HUGEINTandDECIMAL(38)sums when lower per-PU or upper filterless aggregation exceeds 128 bitsHUGEINT_MIN, and clippedbound * countoverflowRoot cause and design
The lower partial and each upper exact bin previously accumulated directly into
hugeint_t, so a valid query could throw before positive and negative contributions canceled. Early saturation is not valid because it makes the result order-dependent.The common path remains the existing inline
hugeint_t. On actual overflow, the state is promoted into an arena-allocated 192-bit representation: a DuckDBHUGEINTresidue plus a signed count of 128-bit overflows. The residue is updated through DuckDB's unsigned 128-bit representation so wrapping is defined on every compiler. Upper bins use sparse sidecars, leaving the existing 32-byte dense bin layout unchanged.This PR is based directly on
main.Validation
ninja -C build/release1