Skip to content

Validate late research context refusals for upstream #912 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cwschroeder wants to merge 1 commit into
base: validation/pr912-f622d935
Choose a base branch
from
Draft

Validate late research context refusals for upstream #912 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions zig/src/server/cortheon/cortheon_test.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,3 +354,26 @@ test "the web budget ends the research and the reply still comes back without Co
try std.testing.expect(m.get("tool_calls") == null);
try std.testing.expect(std.mem.indexOf(u8, m.strField("content").?, "cortheon_search") == null);
}

test "research expansion keeps a context-window refusal streamed" {
for ([_]u32{ 2000, 2400 }) |window| {
var rig: Rig = .{ .eng = .{ .script = &.{"Zig latest release notes"} } };
try rig.start(true);
defer rig.stop();
rig.srv.info.context_window = window;
var arena: std.heap.ArenaAllocator = .init(gpa);
defer arena.deinit();
const got = try rig.ask(arena.allocator(), "{\"stream\":true,\"max_tokens\":1,\"messages\":[{\"role\":\"user\",\"content\":\"What is the latest release of Zig?\"}]}");
try std.testing.expect(rig.web.searches > 0);
try std.testing.expectEqual(@as(usize, 1), rig.eng.prompts.items.len);
try std.testing.expect(got.opened);
try std.testing.expectEqual(@as(?u16, null), got.status);
try std.testing.expect(got.body == null);
var context_error = false;
for (got.events.items) |event| if (event.get("error")) |err| {
if (err.strField("code")) |code| context_error = std.mem.eql(u8, code, "context_length_exceeded");
};
try std.testing.expect(context_error);
try std.testing.expectEqual(@as(i64, 0), rig.srv.preparing.load(.acquire));
}
}
5 changes: 4 additions & 1 deletion zig/src/server/openai.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,10 @@ const Run = struct {
handed = true;
const sink: chat.Sink = .{ .ctx = &sink_state, .call = StreamSink.call, .begin = StreamSink.begin };
var reply = (if (r.turn) |t| cortheon.loop.stream(t, r.srv, &cx, &r.plan.input, prepared, sink, gone) else chat.generate(r.srv, &cx, prepared, sink, gone)) catch |e| {
if (!sink_state.opened) return r.unsent(&cx, e, field);
if (!sink_state.opened) {
if (e == error.Refused and cx.kind == .context_length) return r.streamedContext(&cx, tools, field);
return r.unsent(&cx, e, field);
}
switch (e) {
error.Cancelled => return,
error.Refused => if (cx.kind != .other and cx.kind != .server) {
Expand Down
Loading